FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.0

Threshold is experimental

Effort is max

Summary

Classes Bugs Errors Missing Classes
198 29 0 0

Files

Class Bugs
org.pircbotx.Channel 1
org.pircbotx.Colors 1
org.pircbotx.Configuration 1
org.pircbotx.IdentServer 1
org.pircbotx.InputParser 5
org.pircbotx.PircBotX 2
org.pircbotx.ReplayServer 1
org.pircbotx.ReplayServer$ReplayPircBotX 1
org.pircbotx.ServerInfo 1
org.pircbotx.User 1
org.pircbotx.UtilSSLSocketFactory 1
org.pircbotx.dcc.DccHandler 1
org.pircbotx.dcc.DccHandler$PendingFileTransfer 2
org.pircbotx.dcc.SendFileTransfer 1
org.pircbotx.exception.DccException 1
org.pircbotx.hooks.Event 1
org.pircbotx.output.OutputRaw 2
org.pircbotx.snapshot.ChannelSnapshot 2
org.pircbotx.snapshot.UserChannelDaoSnapshot 1
org.pircbotx.tools.ConcurrentEnumMap 2

org.pircbotx.Channel

Bug Category Details Line Priority
Return value of java.util.concurrent.CountDownLatch.await(long, TimeUnit) ignored in org.pircbotx.Channel.getMode() CORRECTNESS RV_RETURN_VALUE_IGNORED 213 Medium

org.pircbotx.Colors

Bug Category Details Line Priority
Use of non-localized String.toUpperCase() or String.toLowerCase() in org.pircbotx.Colors.lookup(String) I18N DM_CONVERT_CASE 201 Low

org.pircbotx.Configuration

Bug Category Details Line Priority
Confusing to have methods org.pircbotx.Configuration.getRealName() and org.pircbotx.hooks.events.WhoisEvent.getRealname() BAD_PRACTICE NM_CONFUSING 2455 Low

org.pircbotx.IdentServer

Bug Category Details Line Priority
org.pircbotx.IdentServer.server should be package protected MALICIOUS_CODE MS_PKGPROTECT Medium

org.pircbotx.InputParser

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.pircbotx.Channel to org.pircbotx.snapshot.ChannelSnapshot of return value in org.pircbotx.InputParser.processCommand(String, UserHostmask, String, String, List, ImmutableMap) STYLE BC_UNCONFIRMED_CAST_OF_RETURN_VALUE 506 Low
Unchecked/unconfirmed cast from org.pircbotx.User to org.pircbotx.snapshot.UserSnapshot of return value in org.pircbotx.InputParser.processCommand(String, UserHostmask, String, String, List, ImmutableMap) STYLE BC_UNCONFIRMED_CAST_OF_RETURN_VALUE 507 Low
Unchecked/unconfirmed cast from java.net.Socket to javax.net.ssl.SSLSocket of return value in org.pircbotx.InputParser.processConnect(String, String, String, List) STYLE BC_UNCONFIRMED_CAST_OF_RETURN_VALUE 403 Low
org.pircbotx.InputParser.handleLine(String) uses String.indexOf(String) instead of String.indexOf(int) PERFORMANCE IIO_INEFFICIENT_INDEX_OF 303 Low
org.pircbotx.InputParser.handleLine(String) uses String.indexOf(String) instead of String.indexOf(int) PERFORMANCE IIO_INEFFICIENT_INDEX_OF 304 Low

org.pircbotx.PircBotX

Bug Category Details Line Priority
Redundant nullcheck of org.pircbotx.PircBotX.socket, which is known to be non-null in org.pircbotx.PircBotX.connect() STYLE RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE 266 Medium
Repeated conditional test in org.pircbotx.PircBotX.connect() CORRECTNESS RpC_REPEATED_CONDITIONAL_TEST 266 Low

org.pircbotx.ReplayServer

Bug Category Details Line Priority
Found reliance on default encoding in org.pircbotx.ReplayServer.replay(Configuration$Builder, InputStream, String): new java.io.InputStreamReader(InputStream) I18N DM_DEFAULT_ENCODING 212 High

org.pircbotx.ReplayServer$ReplayPircBotX

Bug Category Details Line Priority
org.pircbotx.ReplayServer$ReplayPircBotX doesn't override PircBotX.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium

org.pircbotx.ServerInfo

Bug Category Details Line Priority
Confusing to have methods org.pircbotx.ServerInfo.getExtBanPrefix() and org.pircbotx.UserHostmask.getExtbanPrefix() BAD_PRACTICE NM_CONFUSING 467 Low

org.pircbotx.User

Bug Category Details Line Priority
Confusing to have methods org.pircbotx.User.isIrcop() and org.pircbotx.hooks.events.WhoisEvent.isIrcOp() BAD_PRACTICE NM_CONFUSING 236 Low

org.pircbotx.UtilSSLSocketFactory

Bug Category Details Line Priority
Unchecked/unconfirmed cast from java.net.Socket to javax.net.ssl.SSLSocket in org.pircbotx.UtilSSLSocketFactory.prepare(Socket) STYLE BC_UNCONFIRMED_CAST 125 Low

org.pircbotx.dcc.DccHandler

Bug Category Details Line Priority
Load of known null value in org.pircbotx.dcc.DccHandler.processDcc(UserHostmask, User, String) STYLE NP_LOAD_OF_KNOWN_NULL_VALUE 103 Medium

org.pircbotx.dcc.DccHandler$PendingFileTransfer

Bug Category Details Line Priority
Confusing to have methods org.pircbotx.dcc.DccHandler$PendingFileTransfer.getFileSize() and org.pircbotx.hooks.events.FileTransferCompleteEvent.getFilesize() BAD_PRACTICE NM_CONFUSING 814 Low
Confusing to have methods org.pircbotx.dcc.DccHandler$PendingFileTransfer.getFilename() and org.pircbotx.hooks.events.FileTransferCompleteEvent.getFileName() BAD_PRACTICE NM_CONFUSING 814 Low

org.pircbotx.dcc.SendFileTransfer

Bug Category Details Line Priority
org.pircbotx.dcc.SendFileTransfer.transferFile() ignores result of java.io.BufferedInputStream.read(byte[], int, int) BAD_PRACTICE RR_NOT_CHECKED 60 Medium

org.pircbotx.exception.DccException

Bug Category Details Line Priority
Class org.pircbotx.exception.DccException defines non-transient non-serializable instance field user BAD_PRACTICE SE_BAD_FIELD Low

org.pircbotx.hooks.Event

Bug Category Details Line Priority
Return value of com.google.common.collect.ComparisonChain.compare(int, int) ignored in org.pircbotx.hooks.Event.compareTo(Event) CORRECTNESS RV_RETURN_VALUE_IGNORED 84 Medium

org.pircbotx.output.OutputRaw

Bug Category Details Line Priority
Dead store to finalMessage in org.pircbotx.output.OutputRaw.rawLineSplit(String, String, String) STYLE DLS_DEAD_LOCAL_STORE 140 Low
Exceptional return value of java.util.concurrent.locks.Condition.await(long, TimeUnit) ignored in org.pircbotx.output.OutputRaw.rawLine(String) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 67 Medium

org.pircbotx.snapshot.ChannelSnapshot

Bug Category Details Line Priority
org.pircbotx.snapshot.ChannelSnapshot doesn't override org.pircbotx.Channel.equals(Object) STYLE EQ_DOESNT_OVERRIDE_EQUALS 1 Medium
Field ChannelSnapshot.mode masks field in superclass org.pircbotx.Channel CORRECTNESS MF_CLASS_MASKS_FIELD Low

org.pircbotx.snapshot.UserChannelDaoSnapshot

Bug Category Details Line Priority
Unchecked/unconfirmed cast from org.pircbotx.User to org.pircbotx.snapshot.UserSnapshot of return value in org.pircbotx.snapshot.UserChannelDaoSnapshot.getUserBot() STYLE BC_UNCONFIRMED_CAST_OF_RETURN_VALUE 98 Low

org.pircbotx.tools.ConcurrentEnumMap

Bug Category Details Line Priority
org.pircbotx.tools.ConcurrentEnumMap defines equals but not hashCode BAD_PRACTICE HE_EQUALS_NO_HASHCODE 56 Medium
Class org.pircbotx.tools.ConcurrentEnumMap implements same interface as superclass STYLE RI_REDUNDANT_INTERFACES 1 Low